[U-Boot] [PATCH v2 2/9] dm: core: Move dev_get_addr() etc. into a separate file

[Masahiro Yamada]

Hi Simon,


2017-05-02 0:18 GMT+09:00 Simon Glass <sjg at chromium.org>:
> Move this group of address-related functions into a new file. These use
> the flat device tree. Future work will provide new versions of these which
> can support the live tree.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>




> diff --git a/include/dm.h b/include/dm.h
> index a179c8a6e3..84f789d807 100644
> --- a/include/dm.h
> +++ b/include/dm.h
> @@ -8,6 +8,7 @@
>  #define _DM_H_
>
>  #include <dm/device.h>
> +#include <dm/fdtaddr.h>
>  #include <dm/platdata.h>
>  #include <dm/uclass.h>


I guess your motivation for 1/9 is this.

If you force all drivers to include these 4 headers,
what is the point of splitting?

No, please do not do this.

Please drop 1/9 and,
add #include <dm/fdtaddr.h> where it is necessary.

I know this is painful, but onetime pain.

Perhaps you can use coccinelle for the conversion?

-- 
Best Regards
Masahiro Yamada