[U-Boot] [PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

Simon Glass sjg at chromium.org
Wed May 17 01:38:48 UTC 2017


On 15 May 2017 at 06:30, Tom Rini <trini at konsulko.com> wrote:
> On Mon, May 15, 2017 at 10:01:32PM +1000, Alex Hixon wrote:
>
>> The config name enabling the rk3399-pinctrl driver is spelled wrong, so
>> it does not get built. This causes SPL to fail during board init.
>>
>> Make rk3399-firefly boot by enabling the pinctrl driver via the correct
>> config name.
>>
>> Signed-off-by: Alex Hixon <alex at alexhixon.com>
>> ---
>>  configs/firefly-rk3399_defconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
>> index f30f131f34..0a4d005975 100644
>> --- a/configs/firefly-rk3399_defconfig
>> +++ b/configs/firefly-rk3399_defconfig
>> @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y
>>  CONFIG_GMAC_ROCKCHIP=y
>>  CONFIG_PINCTRL=y
>>  CONFIG_SPL_PINCTRL=y
>> -CONFIG_ROCKCHIP_RK3399_PINCTRL=y
>> +CONFIG_PINCTRL_ROCKCHIP_RK3399=y
>>  CONFIG_DM_PMIC=y
>>  CONFIG_PMIC_RK8XX=y
>>  CONFIG_REGULATOR_PWM=y
>
> Shouldn't the RK3399 pinctrl driver at least by default y?  Or imply'd ?

Yes that sounds good!

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list