[U-Boot] [PATCH v5 20/33] ARM: i.MX6: sabresd: Add dm_gpio_* for backlight

[Jagan Teki]

On Thu, May 11, 2017 at 10:53 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Thu, May 4, 2017 at 12:11 PM, Jagan Teki <jagan at openedev.com> wrote:
>> From: Jagan Teki <jagan at amarulasolutions.com>
>>
>> For OF_CONTROL, gpio's need to configure through
>> dm_gpio_* calls instead of non-dm gpio code, So
>> add dm_gpio_* calls for dts supported code.
>>
>> Cc: Stefano Babic <sbabic at denx.de>
>> Cc: Fabio Estevam <fabio.estevam at nxp.com>
>> Cc: Michael Trimarchi <michael at amarulasolutions.com>
>> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
>> ---
>>  board/freescale/mx6sabresd/mx6sabresd.c | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
>> index 3f73b9b..1df81b9 100644
>> --- a/board/freescale/mx6sabresd/mx6sabresd.c
>> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
>> @@ -190,7 +190,29 @@ static iomux_v3_cfg_t const bl_pads[] = {
>>  static void enable_backlight(void)
>>  {
>>         imx_iomux_v3_setup_multiple_pads(bl_pads, ARRAY_SIZE(bl_pads));
>> +
>> +#ifdef CONFIG_OF_CONTROL
>> +       struct gpio_desc backlight;
>> +       int ret;
>> +
>> +       /* Set Brightness to high */
>> +       ret = dm_gpio_lookup_name("GPIO1_21", &backlight);
>
> Can't we avoid such hardcoded GPIO and use dts to retrieve it?

I think this backlight IMX_GPIO_NR(1, 21) gpio is related to board
code here in U-boot, couldn't see the node related to this on dts.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.