[U-Boot] [PATCH v2] net: usb: mcs7830: fix no DM recive path
Marek Vasut
marex at denx.de
Thu May 18 09:17:08 UTC 2017
On 05/18/2017 11:04 AM, Uri Mashiach wrote:
> The function mcs7830_recv_common() returns a negative value on error, 0
> or positive value on success.
>
> Modifications:
So you want to drop this "Modifications" part and just somehow grind
these two lines into the commit message.
> * Fix the condition for calling the function net_process_received_packet().
> * The return value of the function mcs7830_recv() reflects the success of
> the function mcs7830_recv_common().
>
> Signed-off-by: Uri Mashiach <uri.mashiach at compulab.co.il>
> ---
> v1 -> v2: update the commit message.
>
> drivers/usb/eth/mcs7830.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/eth/mcs7830.c b/drivers/usb/eth/mcs7830.c
> index 9d6cf8c..4abef5d 100644
> --- a/drivers/usb/eth/mcs7830.c
> +++ b/drivers/usb/eth/mcs7830.c
> @@ -622,10 +622,12 @@ static int mcs7830_recv(struct eth_device *eth)
> int len;
>
> len = mcs7830_recv_common(ueth, buf);
> - if (len <= 0)
> + if (len >= 0) {
> net_process_received_packet(buf, len);
> + return 0;
> + }
>
> - return 0;
> + return len;
> }
>
> /*
>
--
Best regards,
Marek Vasut
More information about the U-Boot
mailing list