[U-Boot] [PATCH 36/38] common: arm: davinci: Move header file out of common

[Simon Glass]

Hi Tom,

On 17 May 2017 at 15:33, Tom Rini <trini at konsulko.com> wrote:
> On Wed, May 17, 2017 at 08:23:09AM -0600, Simon Glass wrote:
>
>> We should not have an arch-specific header file in common.h. Instead, use
>> the asm/hardware.h header to provide the required declarations, and drop
>> the common.h changes.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> I'm not a super fan of adding #include to config.h files, but I'll see
> if they can be dropped when testing the series.
>
> Reviewed-by: Tom Rini <trini at konsulko.com>

Me neither. The problem is things like CONFIG_SYS_LOAD_ADDR in
common/image.c which rely on things in asm/hardware. I suppose you
could include it from asm/u-boot.h, but I'm not sure if that is better
or not.

Regards,
Simon