[U-Boot] [PATCH v2 2/2] test: py: hush: Add echo dependency

Stephen Warren swarren at wwwdotorg.org
Thu May 18 16:27:34 UTC 2017


On 05/18/2017 01:23 AM, Michal Simek wrote:
> Some tests depends on echo command to be present.

> diff --git a/test/py/tests/test_hush_if_test.py b/test/py/tests/test_hush_if_test.py

> + at pytest.mark.buildconfigspec('cmd_echo')
>   @pytest.mark.parametrize('expr,result', subtests)
>   def test_hush_if_test(u_boot_console, expr, result):
>       """Test a single "if test" condition."""

This change is technically correct I admit.

However, there's not much point allowing test_hush_if_test_setup() and 
test_hush_if_test_teardown() to run if test_hush_if_test() doesn't run, 
so I'd be inclined to make this a file-level mark rather than a 
function-/test-level mark, just like the other mark for the dependency 
on CONFIG_HUSH_PARSER.

Still, either way is OK I guess.


More information about the U-Boot mailing list