[U-Boot] [PATCH 3/6] SPL: Add XIP booting support

[Alexandru Gagniuc]

On 05/18/2017 11:49 AM, Vikas Manocha wrote:
> Enable support for XIP (execute in place) of U-Boot or kernel image. There is
> no need to copy image from flash to ram if flash supports execute in place.

Awesome. I've had to hack u-boot before to achieve exactly this. It's 
nice to have a proper implementation.


[snip]

> diff --git a/board/st/stm32f746-disco/stm32f746-disco.c b/board/st/stm32f746-disco/stm32f746-disco.c
> index 4f2b677..e330b1f 100644
> --- a/board/st/stm32f746-disco/stm32f746-disco.c
> +++ b/board/st/stm32f746-disco/stm32f746-disco.c
> @@ -91,6 +91,7 @@ int board_early_init_f(void)
>  #endif
>
>  #ifdef CONFIG_SPL_BUILD
> +
Unrelated change.

[snip]

> diff --git a/common/spl/spl_xip.c b/common/spl/spl_xip.c
> new file mode 100644
> index 0000000..50e2f34
> --- /dev/null
> +++ b/common/spl/spl_xip.c
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (C) 2017 Vikas Manocha <vikas.manocha at st.com>
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <spl.h>
> +
> +static int spl_xip(struct spl_image_info *spl_image,
> +		   struct spl_boot_device *bootdev)
> +{
> +#ifdef CONFIG_SPL_OS_BOOT
> +	if (!spl_start_uboot()) {
> +		spl_image->arg = (void *)CONFIG_SYS_FDT_BASE;
> +		spl_image->name = "Linux";
> +		spl_image->os = IH_OS_LINUX;
> +		spl_image->load_addr = CONFIG_SYS_LOAD_ADDR;
> +		spl_image->entry_point = CONFIG_SYS_LOAD_ADDR;
> +#ifdef CONFIG_CPU_V7M

This looks like it should be handled by spl_set_header_raw_uboot(). I 
don't see other SPL loaders do this.

> +		spl_image->entry_point |= 0x1;
> +#endif
> +		debug("spl: payload xipImage, load addr: 0x%lx\n",
> +		      spl_image->load_addr);
> +		return 0;
> +	}
> +#endif
> +	return(spl_parse_image_header(spl_image, (const struct image_header *)
> +	       CONFIG_SYS_UBOOT_BASE));
> +}
> +SPL_LOAD_IMAGE_METHOD("XIP", 0, BOOT_DEVICE_XIP, spl_xip);
>

Alex