[U-Boot] [PATCH 2/4] dts: socfpga: Add trigger-address property to QSPI device

Rush, Jason A. Jason.Rush at gd-ms.com
Fri May 19 16:29:41 UTC 2017


On 5/19/2017 1:09 AM , Marek Vasut wrote:
> On 05/18/2017 08:26 PM, Rush, Jason A. wrote:
>> Add the 'cdns,trigger-address' property to the cadence QSPI device
>> node for Altera SoC devices.
>>
>> Signed-off-by: Jason A. Rush <jason.rush at gd-ms.com>
> 
> +CC Dinh, is that address correct ? I think there was some discussion.

There was some discussion on this before here:
https://lists.denx.de/pipermail/u-boot/2017-March/282882.html

> Jason, I'd rather prefer if you sent this as a series (with git
> send-email) not as a set of separate patches. Also, I'd prefer if you
> would just sync up the whole block with standard agreed-upon (linux)
> DT bindings and then ev. tweak the driver.
>

I can't use git send-email from this email account, but I can switch to my
personal gmail account which should work.  I'll CC my other account and
switch to using that from now on.

I can try and sync up the DT bindings with Linux, most of the parameters
should be easy enough to convert.  However, there are two bindings that
the u-boot driver defines but Linux looks them up from a table or from
querying the flash part ("page-size" and "block-size"), and one binding
Linux defines where u-boot calculates ("cdns,read-delay").

It would require significant changes to the u-boot driver to adopt these
3 bindings, would it be acceptable to align all the other DT bindings, with
the exception of those 3 bindings?
 
--
Regards,
Jason Rush


More information about the U-Boot mailing list