[U-Boot] [PATCH v2 4/4] sunxi: video: Add H3/H5 TV out driver

[Jernej Škrabec]

Hi Maxime,

Dne ponedeljek, 22. maj 2017 ob 09:35:56 CEST je Maxime Ripard napisal(a):
> On Fri, May 19, 2017 at 05:41:17PM +0200, Jernej Skrabec wrote:
> > This commit adds support for TV (composite) output.
> > 
> > Because there is no mechanism to select TV standard, PAL is
> > hardcoded.
> 
> I'd rather use a consistent mechanism with the old driver (even if we
> only support PAL right now and reject any other option), and using
> composite-pal as monitor.
> 

I have few arguments against that:

1. Code for parsing that env variable is in videomodes.[c|h], which is clearly 
a part of an older video framework (ctfb). I didn't want to include any legacy 
code.

2. Even if this code is used for parsing, it would bring a lot of confusion. 
For now, we can say that docs/README.video does not apply to H3 and newer 
SoCs. If we implement this only partially, we would need to describe in 
details which of each setting is honored with the new driver and which not. 
Even then, a lot of users would skip that description and complain anyway.

3. If anything is done in this direction, I think that it is better to extend 
DM video framework so other drivers would benefit from that work too.

Best regards,
Jernej