[U-Boot] [PATCH 2/2] sunxi: A64: (re-)add sun8i emac DT nodes

[Tom Rini]

On Tue, May 23, 2017 at 10:32:06AM +0100, Andre Przywara wrote:
> Hi Tom,
> 
> On 22/05/17 21:49, Tom Rini wrote:
> > On Mon, May 22, 2017 at 01:59:33AM +0100, Andre Przywara wrote:
> >> As the kernel DT does not have an Ethernet driver and bindings, lets
> >> (re-)add the DT bindings for U-Boot's sun8i EMAC Ethernet driver, which
> >> got lost when syncing the kernel DT to U-Boot.
> >> This slightly updates the DT nodes to adapt to the new DT (clock and
> >> reset nodes), but keeps the rest the same to let it work with the
> >> existing U-Boot driver.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> >> ---
> >>  arch/arm/dts/sun50i-a64-pine64-plus.dts | 14 +++++++++++++-
> >>  arch/arm/dts/sun50i-a64-pine64.dts      |  1 +
> >>  arch/arm/dts/sun50i-a64.dtsi            | 33 +++++++++++++++++++++++++++++++++
> > 
> > NAK, please start making use of -u-boot.dtsi files for these so they
> > won't keep getting lost.
> 
> Ah, thanks for the heads up, wasn't aware of that.
> I changed this patch, it looks quite neat now since this non-standard
> binding is now in a separate file and the original .dts files match
> exactly the Linux versions. Also it is expected that we will need to
> change these nodes anyway to match the upcoming Linux Ethernet bindings.
> 
> One thing I noticed is that the binman/ node got lost with this
> approach, is that because the -u-boot.dtsi scheme can only deal with one
> addon file and stops looking on the first hit (skipping sunxi-u-boot.dtsi)?

Ah, I think we've found another problem to fix then, yes.  Today we only
allow one -u-boot.dtsi, but really we should allow for N of them, and
allow for more specific ones (ie board-u-boot.dtsi) to override less
specific (ie soc-u-boot.dtsi) ones, just like regular DTS files, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170523/c7753b18/attachment.sig>