[U-Boot] [PATCH V6 4/4] rockchip: rk3288: enable rockusb support on rk3288 based device

Eddie Cai eddie.cai.linux at gmail.com
Thu May 25 08:40:17 UTC 2017


2017-05-25 8:05 GMT+08:00 Simon Glass <sjg at chromium.org>:
> Hi Eddie,
>
> On 23 May 2017 at 19:43, Eddie Cai <eddie.cai.linux at gmail.com> wrote:
>> 2017-05-24 8:44 GMT+08:00 Simon Glass <sjg at chromium.org>:
>>> Hi Eddie,
>>>
>>> On 22 May 2017 at 00:43, Eddie Cai <eddie.cai.linux at gmail.com> wrote:
>>>> this patch enable rockusb support on rk3288 based device.
>>>>
>>>> Signed-off-by: Eddie Cai <eddie.cai.linux at gmail.com>
>>>>
>>>> Changes in v6:
>>>> -enable rockusb in defconfig
>>>>
>>>> Changes in v5:
>>>> -none
>>>>
>>>> Changes in v4:
>>>> -move to rk3288_common.h
>>>>
>>>> Changes in v3:
>>>> -move to defconfig
>>>>
>>>> ---
>>>>  configs/evb-rk3288_defconfig      | 11 +++++++++++
>>>>  configs/fennec-rk3288_defconfig   |  8 ++++++++
>>>>  configs/firefly-rk3288_defconfig  |  8 ++++++++
>>>>  configs/miqi-rk3288_defconfig     |  8 ++++++++
>>>>  configs/popmetal-rk3288_defconfig |  8 ++++++++
>>>>  configs/tinker-rk3288_defconfig   |  8 ++++++++
>>>>  include/configs/rk3288_common.h   |  7 -------
>>>>  7 files changed, 51 insertions(+), 7 deletions(-)
>>>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>>
>>> But can you use imply in the Kconfig to enable this for all rk2388 boards?
>> I found only SPL things use imply in the Kconfig. Will it be compiled
>> to SPL if i do so?
>
> The 'imply' keyword only affects the config, it is separate from SPL / non-SPL.
>
> If you add imply statements to rk3288 Kconfig, then use 'make
> savedefconfig' should drop them from defconfig.
OK, I will do it in next version
>
> Regards,
> Simon


More information about the U-Boot mailing list