[U-Boot] [PATCH v1 4/8] rockchip: mkimage: rksd: pad SD/MMC images to a full blocksize

[Andy Yan]

Hi Philipp, Simon:

2017-04-17 23:48 GMT+08:00 Philipp Tomsich <
philipp.tomsich at theobroma-systems.com>:

> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> ---
>
>  tools/rksd.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/rksd.c b/tools/rksd.c
> index 6dafedf..8627b6d 100644
> --- a/tools/rksd.c
> +++ b/tools/rksd.c
> @@ -62,8 +62,11 @@ static int rksd_check_image_type(uint8_t type)
>  static int rksd_vrec_header(struct image_tool_params *params,
>                             struct image_type_params *tparams)
>  {
> -       /* We don't add any additional padding after the end of the image
> */
> -       return rkcommon_vrec_header(params, tparams, 1);
> +       /*
> +        * Pad to the RK_BLK_SIZE (512 bytes) to be consistent with
> init_size
> +        * being encoded in RK_BLK_SIZE units in header0 (see rkcommon.c).
> +        */
> +       return rkcommon_vrec_header(params, tparams, RK_BLK_SIZE);
>

     This is another case that breaks BACK_TO_BROM function, as you
documented in [1]:
     The init_size has to be a multiple of 4 blocks (i.e. of 2K)
or the BootROM will not boot the image. So you need to pad the spl to 2kb
aligned.

[1]https://www.mail-archive.com/u-boot@lists.denx.de/msg245573.html






> +        * .
>
>
>  /*
> --
> 1.9.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>