[U-Boot] [PATCH 3/3] marvell: armada385: Add the Turris Omnia board

[Andreas Färber]

Hi Pavel,

Am 28.05.2017 um 21:17 schrieb Pavel Machek:
>> Signed-off-by: Marek Behun <marek.behun at nic.cz>
[...]
>> +++ b/arch/arm/dts/armada-385-turris-omnia.dts
>> @@ -0,0 +1,428 @@
>> +/*
>> + * Device Tree file for the Turris Omnia
>> + *
>> + * Copyright (C) 2014 Marvell
>> + *
>> + * Marek Behun <marek.behun at nic.cz)
> 
> There should be > at end of line.
> 
>> + * Gregory CLEMENT <gregory.clement at free-electrons.com>
> 
> And if you want to claim copyright, you should also specify years...
> 
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPL or the X11 license, at your option. Note that this dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + *  a) This file is licensed under the terms of the GNU General Public
>> + *     License version 2.  This program is licensed "as is" without
>> + *     any warranty of any kind, whether express or implied.
>> + *
>> + * Or, alternatively,
>> + *
>> + *  b) Permission is hereby granted, free of charge, to any person
>> + *     obtaining a copy of this software and associated documentation
>> + *     files (the "Software"), to deal in the Software without
>> + *     restriction, including without limitation the rights to use,
>> + *     copy, modify, merge, publish, distribute, sublicense, and/or
>> + *     sell copies of the Software, and to permit persons to whom the
>> + *     Software is furnished to do so, subject to the following
>> + *     conditions:
>> + *
>> + *     The above copyright notice and this permission notice shall be
>> + *     included in all copies or substantial portions of the Software.
>> + *
>> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + *     OTHER DEALINGS IN THE SOFTWARE.
>> + */
> 
> We normally use spdx license tags in u-boot.

.dts files are imported from Linux, so neither the license text nor the
copyrights should be changed. The kernel file does not have the > bug,
so there's rather a workflow problem here...

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/boot/dts/armada-385-turris-omnia.dts

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)