[U-Boot] [PATCH v2] armv7m: Fix larger builds

Phil Edworthy phil.edworthy at renesas.com
Wed May 31 14:24:13 UTC 2017


Hi Tom,

On 31 May 2017 14:10 Tom Rini wrote:
> On Wed, May 31, 2017 at 08:27:05AM +0100, Phil Edworthy wrote:
> 
> > The branch instruction only has an 11-bit relative target address,
> > which is sometimes not enough.
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy at renesas.com>
> > ---
> > v2:
> >  - Use W(b) instead of ldr+mov. Using this macro requires
> >    CONFIG_ARM_ASM_UNIFIED and CONFIG_THUMB2_KERNEL to be
> defined.
> > ---
> >  arch/arm/cpu/armv7m/Makefile | 3 +++
> >  arch/arm/cpu/armv7m/start.S  | 4 +++-
> >  2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/cpu/armv7m/Makefile
> > b/arch/arm/cpu/armv7m/Makefile index 257fc7f..df1fc95 100644
> > --- a/arch/arm/cpu/armv7m/Makefile
> > +++ b/arch/arm/cpu/armv7m/Makefile
> > @@ -8,3 +8,6 @@
> >  extra-y := start.o
> >  obj-y += cpu.o cache.o mpu.o
> >  obj-$(CONFIG_SYS_ARCH_TIMER) += systick-timer.o
> > +
> > +asflags-y += -DCONFIG_ARM_ASM_UNIFIED asflags-y +=
> > +-DCONFIG_THUMB2_KERNEL
> 
> Lets move these two symbols to Kconfig and select them on CPU_V7M,
> thanks!

These two symbols come from Linux asm files that have been simply
copied over to U-Boot, they are not configuration options in U-Boot.
They are used by both CPU_V7M and others.

Perhaps I have misunderstood, but for non-CPU_V7M, since
CONFIG_THUMB2_KERNEL depends on CONFIG_SYS_THUMB_BUILD,
are you asking me to add Kconfig for CONFIG_SYS_THUMB_BUILD?

Thanks
Phil

> --
> Tom


More information about the U-Boot mailing list