[U-Boot] [PATCH 0/6] i.MX6Q: Add SPL_OF_CONTROL support

[Stefano Babic]

Hi Jagan,

On 19/09/2017 20:37, Jagan Teki wrote:
> From: Jagan Teki <jagan at amarulasolutions.com>
> 
> This series add OF_CONTROL support for SPL on Engicam i.MX6QDL
> boards, along with proper code optimzation changes.
> 
> 
> Jagan Teki (6):
>   i.MX6: engicam: Fix MAINTAINERS/README
>   imx6ul: geam6ul/isiot: Fix to MMC devices
>   i.MX6: engicam: Move set_fdt_file to common
>   i.MX6Q: icorem6: Move spl load fit to common/spl
>   i.MX6Q: icore: Add SPL_OF_CONTROL support
>   i.MX6Q: icore: Add imx6q board for icore/icore_rqs
> 
>  arch/arm/dts/imx6qdl-icore-rqs.dtsi                |   2 +
>  arch/arm/dts/imx6qdl-icore.dtsi                    |   2 +
>  arch/arm/dts/imx6qdl.dtsi                          |   5 +
>  arch/arm/mach-imx/mx6/Kconfig                      |  24 +--
>  board/engicam/common/board.c                       |  24 +++
>  board/engicam/common/board.h                       |   1 -
>  board/engicam/common/spl.c                         |  16 ++
>  board/engicam/geam6ul/MAINTAINERS                  |   2 +-
>  board/engicam/geam6ul/geam6ul.c                    |   6 -
>  board/engicam/icorem6/README                       |  33 ----
>  board/engicam/icorem6_rqs/Kconfig                  |  12 --
>  board/engicam/icorem6_rqs/MAINTAINERS              |   9 --
>  board/engicam/icorem6_rqs/Makefile                 |   6 -
>  board/engicam/icorem6_rqs/icorem6_rqs.c            | 171 ---------------------
>  board/engicam/{icorem6 => imx6q}/Kconfig           |   2 +-
>  board/engicam/{icorem6 => imx6q}/MAINTAINERS       |  10 +-
>  board/engicam/{icorem6 => imx6q}/Makefile          |   2 +-
>  board/engicam/{icorem6_rqs => imx6q}/README        |  12 +-
>  board/engicam/{icorem6/icorem6.c => imx6q/imx6q.c} | 108 +++----------
>  board/engicam/isiotmx6ul/MAINTAINERS               |   2 +-
>  board/engicam/isiotmx6ul/isiotmx6ul.c              |  11 --
>  configs/imx6qdl_icore_mmc_defconfig                |   1 +
>  configs/imx6qdl_icore_rqs_defconfig                |   3 +-
>  configs/imx6ul_geam_mmc_defconfig                  |   1 -
>  configs/imx6ul_isiot_emmc_defconfig                |   1 -
>  configs/imx6ul_isiot_mmc_defconfig                 |   1 -
>  include/configs/imx6-engicam.h                     |  22 +--
>  27 files changed, 112 insertions(+), 377 deletions(-)
>  delete mode 100644 board/engicam/icorem6/README
>  delete mode 100644 board/engicam/icorem6_rqs/Kconfig
>  delete mode 100644 board/engicam/icorem6_rqs/MAINTAINERS
>  delete mode 100644 board/engicam/icorem6_rqs/Makefile
>  delete mode 100644 board/engicam/icorem6_rqs/icorem6_rqs.c
>  rename board/engicam/{icorem6 => imx6q}/Kconfig (87%)
>  rename board/engicam/{icorem6 => imx6q}/MAINTAINERS (51%)
>  rename board/engicam/{icorem6 => imx6q}/Makefile (80%)
>  rename board/engicam/{icorem6_rqs => imx6q}/README (68%)
>  rename board/engicam/{icorem6/icorem6.c => imx6q/imx6q.c} (73%)
> 

I cannot build your boards when I apply the patchset
(CONFIG_SYS_FSL_ESDHC_ADDR is away now):


Building current source for 8 boards (8 threads, 1 job per thread)
       arm:  +   imx6ul_isiot_emmc
+drivers/mmc/fsl_esdhc.c: In function 'fsl_esdhc_mmc_init':
+drivers/mmc/fsl_esdhc.c:934:20: error: 'CONFIG_SYS_FSL_ESDHC_ADDR'
undeclared (first use in this function)
+  cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;
+                    ^
+drivers/mmc/fsl_esdhc.c:934:20: note: each undeclared identifier is
reported only once for each function it appears in
+make[4]: *** [spl/drivers/mmc/fsl_esdhc.o] Error 1
+make[3]: *** [spl/drivers/mmc] Error 2
+make[2]: *** [spl/drivers] Error 2
+make[1]: *** [spl/u-boot-spl] Error 2
+make: *** [sub-make] Error 2
       arm:  +   imx6ul_geam_mmc
+drivers/mmc/fsl_esdhc.c: In function 'fsl_esdhc_mmc_init':
+drivers/mmc/fsl_esdhc.c:934:20: error: 'CONFIG_SYS_FSL_ESDHC_ADDR'
undeclared (first use in this function)
+  cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;
+                    ^
+drivers/mmc/fsl_esdhc.c:934:20: note: each undeclared identifier is
reported only once for each function it appears in
+make[4]: *** [spl/drivers/mmc/fsl_esdhc.o] Error 1
+make[3]: *** [spl/drivers/mmc] Error 2
+make[2]: *** [spl/drivers] Error 2
+make[1]: *** [spl/u-boot-spl] Error 2
+make: *** [sub-make] Error 2
       arm:  +   imx6ul_isiot_mmc
+drivers/mmc/fsl_esdhc.c: In function 'fsl_esdhc_mmc_init':
+drivers/mmc/fsl_esdhc.c:934:20: error: 'CONFIG_SYS_FSL_ESDHC_ADDR'
undeclared (first use in this function)
+  cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;

Could you take a look, please ?

Thanks,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================