[U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset Manager driver for Stratix10 SoC

[Dinh Nguyen]

On Fri, Sep 29, 2017 at 7:53 AM, See, Chin Liang
<chin.liang.see at intel.com> wrote:
> On Tue, 2017-09-26 at 17:08 -0500, Dinh Nguyen wrote:
>> On Tue, Sep 19, 2017 at 4:22 AM,  <chin.liang.see at intel.com> wrote:
>> >
>> > From: Chin Liang See <chin.liang.see at intel.com>
>> >
>> > Add Reset Manager driver support for Stratix SoC
>> >
>> > Signed-off-by: Chin Liang See <chin.liang.see at intel.com>
>> > ---
>> >  arch/arm/mach-socfpga/Makefile                     |   1 +
>> >  arch/arm/mach-socfpga/include/mach/reset_manager.h |   2 +
>> >  .../mach-socfpga/include/mach/reset_manager_s10.h  | 116
>> > +++++++++++++++++
>> >  arch/arm/mach-socfpga/reset_manager.c              |   5 +
>> >  arch/arm/mach-socfpga/reset_manager_s10.c          | 140
>> > +++++++++++++++++++++
>> I don't see why you need to add a new file for S10? The functionality
>> between
>> Gen 5 and Stratix10 is identical for the reset manager.
>
> Not really, they have same functions name but sequences are difference
> due to diff interconnect technology. Hence, try to avoid too much #if
> #else
>

How so? I'm able to re-use the same driver for Linux on the Stratix10.

Dinh