[U-Boot] [PATCH 002/080] mpc83xx: spd_sdram: Fix whitespace style violations
Mario Six
mario.six at gdsys.cc
Wed Oct 4 06:14:41 UTC 2017
Hi Wolfgang,
On Fri, Sep 29, 2017 at 4:03 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Mario,
>
> In message <20170929125238.26226-2-mario.six at gdsys.cc> you wrote:
>> Fix whitespace style violations in the MPC83xx SPD-SDRAM code.
> ...
>
>> - ddr->csbnds[1].csbnds = ( (banksize(spd.row_dens) >> 8)
>> - | ((banksize(spd.row_dens) >> 23) - 1) );
>> ddr->cs_config[1] = ( 1<<31
>> + ddr->csbnds[1].csbnds = ((banksize(spd.row_dens) >> 8)
>> + | ((banksize(spd.row_dens) >> 23) - 1));
>> | (odt_rd_cfg << 20)
>> | (odt_wr_cfg << 16)
>> | ((spd.nbanks == 8 ? 1 : 0) << 14)
>> | ((spd.nrow_addr - 12) << 8)
>
> This looks as if you were changing the code, and not only whitespace ?
>
> I would expect that this does not even compile!
>
Argh, something went wrong when I split the commits; this and the next commit
were originally a single commit, but I split them in order to be more readable
(the next commit fixes the order of the lines again).
> Which sort of testing did you give to this patch series?
>
I tested the final, and some of the larger patches using buildman, but not
these ones. I'll put the entire series through the wringer for v2. Terribly
sorry for that.
> Best regards,
>
> Wolfgang Denk
>
Best regards,
Mario
More information about the U-Boot
mailing list