[U-Boot] [PATCH 1/1] efi_loader: replace efi_div10 by div64_u64

Alexander Graf agraf at suse.de
Thu Oct 5 12:55:46 UTC 2017



On 03.10.17 05:17, Heinrich Schuchardt wrote:
> We should use the existing 64bit division instead of
> reinventing the wheel.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

This patch increases the code size by ~200 bytes on armv7 with gcc7 for 
me. I'm not sure about the runtime - it's probably much slower too.

I do agree however that lib/efi_loader is not necessarily the right 
place to put base math things.

How about we just rename the efi_div10 to div64_10 and move it to 
lib/div64.c?


Alex


More information about the U-Boot mailing list