[U-Boot] [PATCH] cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity

Tom Rini trini at konsulko.com
Sun Oct 8 15:11:41 UTC 2017


On Sat, Oct 07, 2017 at 08:19:21PM -0400, Tom Rini wrote:

> The recent changes to these files did not completely fix the previous
> issues, or introduced different (minor) issues.  In cmd/gpt.c we need to
> dereference str_disk_guid to be sure that malloc worked.  In
> cmd/nvedit.c we need to be careful that we can also fit in that leading
> space when adding to the string.  And in tools/fit_image.c we need to
> re-work the error handling slightly in fit_import_data() so that we only
> call munmap() once.  We have two error paths here, one where we have an
> fd to close and one where we do not.  Adjust labels to match this.
> 
> Reported-by: Coverity (CID: 167366, 167367, 167370)
> Signed-off-by: Tom Rini <trini at konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171008/7821aefc/attachment.sig>


More information about the U-Boot mailing list