[U-Boot] [PATCH v2 1/1] efi_selftest: make tests easier to read

[Simon Glass]

Hi Heinrich,

On 4 October 2017 at 07:31, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> Rename counter to more illustrative names.
> Update notification function description.
> Simplify notification function.
> Add comment for arbitrary non-zero value.
> Document @return.
> Use constants for return values of setup, execute, teardown.
>
> Reported-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
> v2:
>         Remove superfluous blank in a message text.
> ---
>  include/efi_selftest.h                           |  3 +
>  lib/efi_selftest/efi_selftest.c                  | 15 +++--
>  lib/efi_selftest/efi_selftest_events.c           | 80 ++++++++++++----------
>  lib/efi_selftest/efi_selftest_exitbootservices.c | 46 +++++++------
>  lib/efi_selftest/efi_selftest_tpl.c              | 85 +++++++++++++-----------
>  5 files changed, 129 insertions(+), 100 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

But I am not that keen on returning SUCCESS instead of 0. I think 0 is
well understood and easier on the eye.

Regards,
Simon