[U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc capabilities

Simon Glass sjg at chromium.org
Mon Oct 9 04:48:30 UTC 2017


On 2 October 2017 at 02:57, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
> Hi Jaehoon,
>
>
> On 22/09/2017 15:54, Jaehoon Chung wrote:
>>
>> Hi,
>>
>> On 09/21/2017 11:29 PM, Jean-Jacques Hiblot wrote:
>>>
>>> This adds a simple helper function to display information (bus width and
>>> mode) based on a capability mask. Useful for debug.
>>
>> I agreed this is useful.. but there is no usage in your patch.
>> How did you use this? and Where does call this function..
>>
>> I think it can be used the one of mmc command. how about?
>
> At first I added it to "mmc info" but it's more for the developer than the
> user, so I removed it from there.
> At the moment it is not referenced anywhere the code, but I left it in place
> because it's indeed useful when debugging the initialization.
> Thinking of it I could add something right after the card capabilities are
> discovered if debug is enabled. What do you think?
>
> Jean-Jacques

That seems reasonable.

In any case, we cannot add dead code.

- Simon


More information about the U-Boot mailing list