[U-Boot] [PATCH V2] ARM: imx6: Add DHCOM i.MX6 PDK board support

[Stefano Babic]

Hi Jagan, Marek,

On 10/10/2017 16:08, Marek Vasut wrote:
> On 10/10/2017 04:04 PM, Jagan Teki wrote:
>> On Tue, Oct 10, 2017 at 7:10 PM, Marek Vasut <marex at denx.de> wrote:
>>> On 10/10/2017 03:32 PM, Jagan Teki wrote:
>>>> On Tue, Oct 10, 2017 at 1:21 AM, Marek Vasut <marex at denx.de> wrote:
>>>>> Add support for the DHCOM i.MX6 PDK board. This board has:
>>>>> - FEC ethernet
>>>>> - EHCI USB host
>>>>> - 3x SDMMC
>>>>>
>>>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>>>> Cc: Stefano Babic <sbabic at denx.de>
>>>>> ---
>>>>> V2: Use get_cpu_type() and imx_get_mac_from_fuse()
>>>>> ---
>>>>>  arch/arm/mach-imx/mx6/Kconfig             |  10 +
>>>>>  board/dhelectronics/dh_imx6/Kconfig       |  12 +
>>>>>  board/dhelectronics/dh_imx6/MAINTAINERS   |   7 +
>>>>>  board/dhelectronics/dh_imx6/Makefile      |  11 +
>>>>>  board/dhelectronics/dh_imx6/dh_imx6.c     | 437 ++++++++++++++++++++++++++++++
>>>>>  board/dhelectronics/dh_imx6/dh_imx6_spl.c | 399 +++++++++++++++++++++++++++
>>>>>  configs/dh_imx6_defconfig                 |  51 ++++
>>>>>  include/configs/dh_imx6.h                 | 191 +++++++++++++
>>>>>  8 files changed, 1118 insertions(+)
>>>>>  create mode 100644 board/dhelectronics/dh_imx6/Kconfig
>>>>>  create mode 100644 board/dhelectronics/dh_imx6/MAINTAINERS
>>>>>  create mode 100644 board/dhelectronics/dh_imx6/Makefile
>>>>>  create mode 100644 board/dhelectronics/dh_imx6/dh_imx6.c
>>>>>  create mode 100644 board/dhelectronics/dh_imx6/dh_imx6_spl.c
>>>>>  create mode 100644 configs/dh_imx6_defconfig
>>>>>  create mode 100644 include/configs/dh_imx6.h
>>>>>
>>>>> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
>>>>> index 540f2b29b1..b82db3af22 100644
>>>>> --- a/arch/arm/mach-imx/mx6/Kconfig
>>>>> +++ b/arch/arm/mach-imx/mx6/Kconfig
>>>>> @@ -129,6 +129,15 @@ config TARGET_COLIBRI_IMX6
>>>>>         select DM_SERIAL
>>>>>         select DM_THERMAL
>>>>>
>>>>> +config TARGET_DHCOMIMX6
>>>>> +       bool "dh_imx6"
>>>>> +       select BOARD_LATE_INIT
>>>>> +       select BOARD_EARLY_INIT_F
>>>>> +       select SUPPORT_SPL
>>>>> +       select DM
>>>>> +       select DM_THERMAL
>>>>> +       imply CMD_SPL
>>>>
>>>> I would suggest to add new boards with DTS along with enabling
>>>> dm-driven drivers, this would eventually improve i.MX tree toward
>>>> using new feature set.
>>>
>>> Enabling unused stuff and adding bloat ? Nope :)
>>
>> OK, but we still have useful stuff:
>>
>> DM_ETH
>> DM_GPIO
>> DM_I2C
>> DM_MMC
>> DM_SPI
>> DM_SPI_FLASH
> 
> This discussion is moot, it is NOT useful here and it just adds bloat.

More or less I have already explained my point of view here:

	https://lists.denx.de/pipermail/u-boot/2017-May/292424.html

Again, moving to DTS should be done if this does not preclude other
features. That means for example boot time (==> small footprint), having
a single binary for multiple SOC variants, and so on. As I have already
said: I won't constraint any contributor to follow one or the other way.
See case with pico imx.7. I understand that some projects will be better
supported in one way, some other ones with the other way. I have also
merged boards in last time *without* DTS support, because the board
maintainer is in charge to better know which is the best for his own
project - the choice has low impact on the common port for i.MX. For
this patch, Marek has chosen the way to support the board, because he
won't to increase footprint and he does not want to have unused code
inside. All good arguments.

IMHO patch is fine.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================