[U-Boot] [PATCH 00/11] efi_loader: patches for Shell.efi

[Heinrich Schuchardt]

On 10/10/2017 02:22 PM, Rob Clark wrote:
> Re-send of the patch series to get Shell.efi working, and almost get
> SCT.efi (the UEFI test suite) working.
> 
> Since last time, I've updated to Heinrich's latest SetWatchdogTimer
> patch (as of yesterday evening), and adressed review comments on the
> three new sets of protocols added.  Part of that, to avoid moving
> changes from my later patch that added implementation on top of Leif's
> initial stubs was done by simply squashing the patches together.
> 
> 
> Heinrich Schuchardt (1):
>    efi_loader: implement SetWatchdogTimer
> 
> Leif Lindholm (3):
>    efi_loader: Initial EFI_DEVICE_PATH_UTILITIES_PROTOCOL
>    efi_loader: Initial HII protocols
>    efi_loader: Initial EFI_UNICODE_COLLATION_PROTOCOL
> 
> Rob Clark (7):
>    efi_loader: SIMPLE_TEXT_INPUT_EX plus wire up objects properly
>    efi_loader: console support for color attributes
>    efi_loader: Decouple EFI input/output from stdin/stdout
>    efi_loader: fix events
>    efi_loader: Fix disk dp's for pre-DM/legacy devices
>    efi_loader: Add mem-mapped for fallback
>    efi_loader: exclude openrd devices
> 
>   cmd/bootefi.c                              |  24 ++
>   include/efi_api.h                          | 438 ++++++++++++++++++++++++-
>   include/efi_loader.h                       |  29 +-
>   lib/efi_loader/Kconfig                     |   2 +-
>   lib/efi_loader/Makefile                    |   3 +-
>   lib/efi_loader/efi_boottime.c              | 256 ++++++++-------
>   lib/efi_loader/efi_console.c               | 398 +++++++++++++++++++---
>   lib/efi_loader/efi_device_path.c           |  24 ++
>   lib/efi_loader/efi_device_path_to_text.c   |   9 +
>   lib/efi_loader/efi_device_path_utilities.c |  88 +++++
>   lib/efi_loader/efi_disk.c                  |  11 +
>   lib/efi_loader/efi_hii.c                   | 507 +++++++++++++++++++++++++++++
>   lib/efi_loader/efi_unicode.c               | 170 ++++++++++
>   lib/efi_loader/efi_watchdog.c              |  86 +++++
>   14 files changed, 1861 insertions(+), 184 deletions(-)
>   create mode 100644 lib/efi_loader/efi_device_path_utilities.c
>   create mode 100644 lib/efi_loader/efi_hii.c
>   create mode 100644 lib/efi_loader/efi_unicode.c
>   create mode 100644 lib/efi_loader/efi_watchdog.c
> 


Overall the patch series looks in good shape.

One comment I thought could be helpful in
[PATCH 05/11] efi_loader: console support for color attributes

Some minor checkpatch.pl warnings.

One git am problem (may be a missing space) I had.

I hope we can get this merged now.

Thanks to Rob for driving this.

Regards

Heinrich