[U-Boot] [PATCH 01/11] efi_loader: Initial EFI_DEVICE_PATH_UTILITIES_PROTOCOL

[Heinrich Schuchardt]

On 10/11/2017 10:32 PM, Rob Clark wrote:
> On Wed, Oct 11, 2017 at 10:07 AM, Alexander Graf <agraf at suse.de> wrote:
>>
>>
>> On 10.10.17 14:22, Rob Clark wrote:
>>> From: Leif Lindholm <leif.lindholm at linaro.org>
>>>
>>> Not complete, but enough for Shell.efi and SCT.efi.  We'll implement the
>>> rest as needed or once we have SCT running properly so there is a way to
>>> validate the interface against the conformance test suite.
>>>
>>> Initial skeleton written by Leif, and then implementation by myself.
>>>
>>> Cc: Leif Lindholm <leif.lindholm at linaro.org>
>>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>>> ---
>>>   include/efi_api.h                          | 34 +++++++++++-
>>>   include/efi_loader.h                       |  2 +
>>>   lib/efi_loader/Makefile                    |  1 +
>>>   lib/efi_loader/efi_boottime.c              |  4 ++
>>>   lib/efi_loader/efi_device_path_utilities.c | 88 ++++++++++++++++++++++++++++++
>>>   5 files changed, 127 insertions(+), 2 deletions(-)
>>>   create mode 100644 lib/efi_loader/efi_device_path_utilities.c
>>>
>>> diff --git a/include/efi_api.h b/include/efi_api.h
>>> index a9a6494afe..ffdba7fe1a 100644
>>> --- a/include/efi_api.h
>>> +++ b/include/efi_api.h
>>> @@ -28,8 +28,9 @@ enum efi_timer_delay {
>>>        EFI_TIMER_RELATIVE = 2
>>>   };
>>>
>>> -#define UINTN size_t
>>> -typedef long INTN;
>>> +#define UINTN size_t   /* TODO this should be removed in a future patch */
>>
>> $ git grep UINTN | wc -l
>> 13
>>
>> Just send a preceding patch that introduces efi_uintn_t and replaces all
>> occurences of UINTN with it.
>>
>> The uintn bits shouldn't be part of the
>> EFI_DEVICE_PATH_UTILITIES_PROTOCOL patch anyways :).
>>
> 
> Heinrich mentioned he was doing that, so I didn't want to step on
> feet.  I figured this was the easiest approach regardless of the order
> of merging patches (should be simple enough to drop the duplicate
> efi_uintn_t)

I do not mind if you put the change in one of your patches. Just do what 
is needed to get your patch series merged.

Best regards

Heinrich

> 
> BR,
> -R
> 
>>> +typedef size_t efi_uintn_t;
>>> +typedef ssize_t efi_intn_t;
>>>   typedef uint16_t *efi_string_t;
>>
>>
>> Alex
>