[U-Boot] [PATCH 07/20] usb: dwc3-uniphier: replace <common.h> with <linux/bitops.h>

Marek Vasut marex at denx.de
Fri Oct 13 10:40:10 UTC 2017


On 10/13/2017 12:21 PM, Masahiro Yamada wrote:
> Including <common.h> pulls in a lot of bloat.  What this driver needs
> is BIT(), so replace it with <linux/bitops.h>
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>

Doesn't common.h also pull in the config macros ? Maybe they are not
needed here though ...

> ---
> 
>  drivers/usb/dwc3/dwc3-uniphier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-uniphier.c b/drivers/usb/dwc3/dwc3-uniphier.c
> index 0d13770..25b17a8 100644
> --- a/drivers/usb/dwc3/dwc3-uniphier.c
> +++ b/drivers/usb/dwc3/dwc3-uniphier.c
> @@ -7,8 +7,8 @@
>   * SPDX-License-Identifier:	GPL-2.0+
>   */
>  
> -#include <common.h>
>  #include <dm.h>
> +#include <linux/bitops.h>
>  #include <linux/errno.h>
>  #include <linux/io.h>
>  #include <linux/sizes.h>
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list