[U-Boot] [PATCH 07/20] usb: dwc3-uniphier: replace <common.h> with <linux/bitops.h>

Marek Vasut marex at denx.de
Fri Oct 13 11:10:59 UTC 2017


On 10/13/2017 01:01 PM, Masahiro Yamada wrote:
> Hi Marek,
> 
> 
> 2017-10-13 19:40 GMT+09:00 Marek Vasut <marex at denx.de>:
>> On 10/13/2017 12:21 PM, Masahiro Yamada wrote:
>>> Including <common.h> pulls in a lot of bloat.  What this driver needs
>>> is BIT(), so replace it with <linux/bitops.h>
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>>
>> Doesn't common.h also pull in the config macros ? Maybe they are not
>> needed here though ...
> 
> 
> If you need legacy CONFIG from include/configs/<board>.h,
> yes, you need to include <common.h>
> (or <config.h> at least)
> 
> 
> Recent CONFIG options from Kconfig are automatically provided
> via  -include $(srctree)/include/linux/kconfig.h

OK, so not needed , perfect, thanks.

Acked-by: Marek Vasut <marex at denx.de>

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list