[U-Boot] [PATCH v1 1/3] test/py: gpt: update test_gpt

Patrick DELAUNAY patrick.delaunay at st.com
Mon Oct 16 16:08:42 UTC 2017


Hi Stephen

> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> 
> On 10/10/2017 06:50 AM, Patrick DELAUNAY wrote:
> > Hi Stephen,
> >
> >> -----Original Message-----
> >> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> >>
> >> On 10/09/2017 01:47 AM, Patrick Delaunay wrote:
> >
> > But I don't sure of the correct patchset order to avoid issue during
> > merge in master branch
> >
> > First Test update  => test Failed
> > Then patch the code => test OK
> >
> > Or
> >
> > First patch the code => test Failed
> > Then patch the test => test OK
> 
> I'd suggest something like:
> 
> Patch 1: Modify the test to check the value for all 3 columns in a way that passes
> with the current implementation of the command. Perhaps add a comment that
> there's a bug in the code, and remove it in the next patch. The test should pass
> both before and after this patch.
> 
> Patch 2: Fix the bug in the GPT command, and in the same patch, change the
> values that test_gpt expects so that it passes again. The test should pass both
> before and after this patch.

I will do it as proposed in v2 patch with the test update split

Patrick


More information about the U-Boot mailing list