[U-Boot] [PATCH V2] imx: mx6slevk: fix mmc breakage

Fabio Estevam festevam at gmail.com
Mon Oct 16 16:15:12 UTC 2017


Hi Peng,

Subject should be changed as you are no longer fixing a MMC breakage.

On Mon, Oct 16, 2017 at 10:23 AM, Peng Fan <peng.fan at nxp.com> wrote:
> Log:
>   "
>   MMC Device 1 not found
>   *** Warning - No MMC card found, using default environment

This message should be removed as you are no longer fixing a MMC breakage.

>   "
> Add alias node for usdhc.

Why? Please explain why you need the alias. What happens if the alias
is not added?

Upstream dts file does not have the alias either, so why should we
diverge from upstream dts?

Also, as far as I recall the mmc alias mechanism does not work in the kernel.

We cannot guarantee the probe ordering and we should use UUID to
specify the rootfs location.

> Cleaned up board usb code.

This part is fine and you could do a patch doing only this USB board
code removal.

Thanks


More information about the U-Boot mailing list