[U-Boot] [PATCH v5] cmd: usb: add blk, emulation devices to ignore list as needed

Marek Vasut marex at denx.de
Tue Oct 17 12:43:59 UTC 2017


On 10/17/2017 05:21 AM, Bin Meng wrote:
> +Marek, Tom,

Well, if the author CCed me in the first place, that'd be useful.

> On Tue, Oct 17, 2017 at 11:14 AM, Suneel Garapati
> <suneelglinux at gmail.com> wrote:
>> Hi Bin/Simon,
>>
>> Request to know if this will be applied for v2017.11
>>
> 
> Not sure which of you should pick this up for v2017.11.

The commit message makes no sense, can you explain to me what this patch
tries to achieve ?

>> Regards,
>> Suneel
>>
> 
> Suneel, please avoid top-posting next time. thanks!
> 
>> On Sun, Sep 24, 2017 at 7:13 PM, Simon Glass <sjg at chromium.org> wrote:
>>> On 20 September 2017 at 23:09, Suneel Garapati <suneelglinux at gmail.com> wrote:
>>>> add blk child devices to ignore list while displaying usb tree graph,
>>>> also preamble should not be set for blk child devices.
>>>> add usb_emul to ignore list in usb_show_info. otherwise usb tree and
>>>> info commands may cause crash treating blk as usb device.
>>>>
>>>> Signed-off-by: Suneel Garapati <suneelglinux at gmail.com>
>>>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>>>> Tested-by: Bin Meng <bmeng.cn at gmail.com>
>>>> ---
>>>> Changes v5:
>>>>  - add usb_emul to ignore list in usb_show_info
>>>>  - modify description
>>>> Changes v4:
>>>>  - do not set preamble if child is block device for mass storage
>>>> Changes v3:
>>>>  - remove 'check on parent uclass' in description
>>>> Changes v2:
>>>>  - remove check on parent uclass
>>>> Changes v1:
>>>>  - add separate check on blk uclass
>>>>  - modify description
>>>>  - add separate check on parent uclass as usb
>>>>
>>>>  cmd/usb.c | 22 +++++++++++++++++++---
>>>>  1 file changed, 19 insertions(+), 3 deletions(-)
>>>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Regards,
> Bin
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list