[U-Boot] [PATCH v2 4/4] pylibfdt: compile pylibfdt only when dtoc/binman is necessary
Simon Glass
sjg at chromium.org
Sun Oct 22 14:35:01 UTC 2017
Hi Masahiro,
On 17 October 2017 at 06:42, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> Currently, pylibfdt is always compiled if swig is installed on your
> machine. It is really annoying because most of targets (excepts
> x86, sunxi, rockchip) do not use dtoc or binman.
>
> "checkbinman" and "checkdtoc" are wrong. It is odd that the final
> build stage checks if we have built necessary tools. If your platform
> depends on dtoc/binman, you must be able to build pylibfdt. If swig
> is not installed, it should fail immediately.
>
> I added PYLIBFDT, DTOC, BINMAN entries to Kconfig. They should be
> property select:ed by platforms that need them. Kbuild will descend
> into scripts/dtc/pylibfdt/ only when CONFIG_PYLIBFDT is enabled.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
> Makefile | 17 ++---------------
> arch/arm/Kconfig | 1 +
> arch/x86/Kconfig | 1 +
> dts/Kconfig | 13 +++++++++++++
> scripts/Makefile.spl | 15 ++-------------
> scripts/dtc/Makefile | 2 +-
> 6 files changed, 20 insertions(+), 29 deletions(-)
>
I think this is a reasonable change.
Reviewed-by: Simon Glass <sjg at chromium.org>
Regards,
Simon
More information about the U-Boot
mailing list