[U-Boot] [PATCH 6/9] spi: ich: Lock down controller settings if required

Bin Meng bmeng.cn at gmail.com
Mon Oct 23 01:32:39 UTC 2017


Hi Simon,

On Sun, Oct 22, 2017 at 10:36 PM, Simon Glass <sjg at chromium.org> wrote:
> On 19 October 2017 at 03:20, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Some Intel FSP (like Braswell) does SPI lock-down during the call
>> to fsp_notify(INIT_PHASE_BOOT). But before SPI lock-down is done,
>> it's bootloader's responsibility to configure the SPI controller's
>> opcode registers properly otherwise SPI controller driver doesn't
>> know how to communicate with the SPI flash device.
>>
>> Rather than passively doing the opcode configuration, let's add a
>> simple DTS property "intel,spi-lock-down" and let the driver call
>> the opcode configuration function if required by such FSP.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  drivers/spi/ich.c | 22 ++++++++++++++++++++++
>>  drivers/spi/ich.h |  1 +
>>  2 files changed, 23 insertions(+)
>
> Does this go in a binding file somewhere?
>

Looks there is no binding file for Intel SPI controller driver. We
will need create one.

> Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Bin


More information about the U-Boot mailing list