[U-Boot] [PATCH v3 18/20] arm: socfpga: Enable function visible to other file

[Dinh Nguyen]

On 10/23/2017 03:19 AM, Chee, Tien Fong wrote:
> On Jum, 2017-10-20 at 09:39 -0500, Dinh Nguyen wrote:
>>
>> On 10/13/2017 03:08 AM, tien.fong.chee at intel.com wrote:
>>>
>>> From: Tien Fong Chee <tien.fong.chee at intel.com>
>>>
>>> Enable function visible to other file, so it can be used by other
>>> functions from other file.
>> Huh? What function? What other file? Why?
>>
>> Please bear in mind for future patches, when reading the commit
>> message,
>> you should have a good idea of what the patch is doing without even
>> looking at the patch.
>>
>> Need to include more people listed in get_maintainer.pl
>>
>> Maybe Marek has already commented, but this patch can be separated
>> out
>> from the A10 series.
>>
>> Also, the commit header "arm:socfpga: Enable function visible to
>> other
>> file" is horrible and this patch has nothing to do with socfpga.
>>
> This patch is required by later patches, so this patch can't be
> separated out. This function is static declaration, but this function
> is required by the caller from other file(later patches). So, this
> patch is to remove ths static declaration so it is accessible by the
> caller from other file.

yes, I know what it means to remove the static declaration. Ok, I
understand the need for this patch in this series. Please fix up the
commit header and message.

Dinh