[U-Boot] [PATCH v4 06/20] common: Generic firmware loader for file system

[Chee, Tien Fong]

On Sel, 2017-10-31 at 12:35 +0100, Marek Vasut wrote:
> On 10/31/2017 12:15 PM, Chee, Tien Fong wrote:
> > 
> > On Sel, 2017-10-31 at 12:01 +0100, Marek Vasut wrote:
> > > 
> > > On 10/31/2017 11:52 AM, tien.fong.chee at intel.com wrote:
> > > > 
> > > > 
> > > > From: Tien Fong Chee <tien.fong.chee at intel.com>
> > > > 
> > > > Generic firmware loader framework contains some common
> > > > functionality
> > > > which is reusable by any specific driver file system firmware
> > > > loader.
> > > > Specific driver file system firmware loader handling can be
> > > > defined
> > > > with both weak function fsloader_preprocess and fs_loading.
> > > > 
> > > > Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> > > Why did you put everything into splash_source.c ? If this is
> > > supposed
> > > to
> > > be a generic loader, I'm sure not everyone would want to enable
> > > splash
> > > screen support to get generic firmware loader support.
> > > 
> > > The API should looks more like the linux firmware API.
> > > 
> > Initially, i created the new file called loadfs.c, which contains
> > common codes and generic fs firmware loader. I plan to replace fs
> > loader in splash_source.c at seperate patchset.
> No.
> 
> > 
> > Then, i changed the codes directly on splash_source.c based on your
> > comment. May be i misunderstood your meaning.
> I would never suggest such a thing, sorry. This should be done
> properly
> from the getgo, with proper API and in a separate file. All the
> consumers should be converted to that API.
> 
Okay, that means what i did in ver3 is what you say. Just i included
the generic firmware loader into series because this is required by
fpga loadfs, then i plan to convert splash_loader to use it at later
separate patchset.