[U-Boot] efi_loader: runtime services implementation broken?

[Alexander Graf]

On 07/03/2018 04:24 PM, Bin Meng wrote:
> Hi Alex, Heinrich,
>
> At present not all interfaces in lib/efi_loader/efi_runtime.c are
> declared as __efi_runtime. But only declaring those as __efi_runtime
> is not enough. The data these interfaces use should be declared as
> __efi_runtime_data too. More worse, any U-Boot APIs called by these
> interfaces should be __efi_runtime and __efi_runtime_data
> respectively.

Correct. This is done for everything right now, no?

> Eventually we need mark the RAM where the whole U-Boot image lives as
> runtime service code and data and end up leaving whole U-Boot image in
> the RAM after kernel boots?

Why?

> Right now I am testing booting Linux on Intel Galileo with 'bootefi'
> and kernel just hangs during the boot. Initial debugging shows that
> kernel crashes when calling runtime service
> efi_set_virtual_address_map().

Can you please try with my efi-next branch? I added a few patches that 
allow gcc to put implicit data and code into the runtime section. 
Without those, you may get constant propagation into a the common 
.rodata segment for example.


Alex