[U-Boot] [PATCH v2 2/2] arm: qemu-arm: enable PL031 (RTC) in defconfig

[Heinrich Schuchardt]

On 07/04/2018 10:56 AM, Alexander Graf wrote:
> On 07/04/2018 09:36 AM, AKASHI Takahiro wrote:
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
>> ---
>>   configs/qemu_arm64_defconfig | 2 ++
>>   configs/qemu_arm_defconfig   | 2 ++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
>> index cdf5072fe4..f3e3963860 100644
>> --- a/configs/qemu_arm64_defconfig
>> +++ b/configs/qemu_arm64_defconfig
>> @@ -28,3 +28,5 @@ CONFIG_USB=y
>>   CONFIG_DM_USB=y
>>   CONFIG_USB_EHCI_HCD=y
>>   CONFIG_USB_EHCI_PCI=y
>> +CONFIG_DM_RTC=y
>> +CONFIG_RTC_PL031=y
> 
> Is there any particular reason you don't just do select statements in
> the ARCH_QEMU definition? Or maybe imply?

'select' makes it impossible to switch configuration options off. We
should only use it if really needed. 'imply' is fine here.

Configuration options should appear in *_defconfig files in the same
sequence as in the generated .config file. CONFIG_RTC_PL031 precedes
CONFIG_SCSI.

Please, add a commit message to the next version of the patch.

Best regards

Heinrich

> 
> 
> Alex
> 
>> diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
>> index bbce6cd719..28dfba0283 100644
>> --- a/configs/qemu_arm_defconfig
>> +++ b/configs/qemu_arm_defconfig
>> @@ -28,3 +28,5 @@ CONFIG_USB=y
>>   CONFIG_DM_USB=y
>>   CONFIG_USB_EHCI_HCD=y
>>   CONFIG_USB_EHCI_PCI=y
>> +CONFIG_DM_RTC=y
>> +CONFIG_RTC_PL031=y
> 
> 
>