[U-Boot] [PATCH] rpi: Set the default mmc max device to 2

Emmanuel Vadot manu at bidouilliste.com
Wed Jul 4 07:34:36 UTC 2018


On Wed, 4 Jul 2018 09:25:16 +0200
Alexander Graf <agraf at suse.de> wrote:

> On 07/04/2018 09:08 AM, Emmanuel Vadot wrote:
> > When running with special configuration (OF_BOARD and mmc overlay)
> > RPI have the SD card as id 1.
> > This make device enumeration fails when using the API.
> >
> > Signed-off-by: Emmanuel Vadot <manu at freebsd.org>
> 
> Could you please elaborate a bit? From the commit message I don't fully 
> understand which problem you're trying to solve.
> 
> 
> Thanks,
> 
> Alex

 Sure,

 When using the dtb from the rpi fundation and the mmc overlay (which
switch back the sd card to use the SDHCI controller and not the SDHOST
one) and using OF_BOARD so u-boot uses it/pass it to the OS the device
id for the sd is 1 :
U-Boot> mmc list
mmc at 7e300000: 1

 This cause the API (see api/api_storage.c) code to never expose this
device to the consumer as the default value for
CONFIG_SYS_MMC_MAX_DEVICE is 1.

 If it's more clear I'll send a v2 with those words.

 Cheers,

> > ---
> >   include/configs/rpi.h | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/include/configs/rpi.h b/include/configs/rpi.h
> > index a97550b732..26fc9b9d95 100644
> > --- a/include/configs/rpi.h
> > +++ b/include/configs/rpi.h
> > @@ -69,6 +69,8 @@
> >   #define CONFIG_MISC_INIT_R
> >   #endif
> >   
> > +#define CONFIG_SYS_MMC_MAX_DEVICE	2
> > +
> >   /* Console configuration */
> >   #define CONFIG_SYS_CBSIZE		1024
> >   


-- 
Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>


More information about the U-Boot mailing list