[U-Boot] [PATCH 3/5] net: Make copy_filename() accept NULL src

Joe Hershberger joe.hershberger at ni.com
Wed Jul 4 16:18:37 UTC 2018


On Wed, Jul 4, 2018 at 4:25 AM, Alexander Graf <agraf at suse.de> wrote:
> On 07/04/2018 02:36 AM, Joe Hershberger wrote:
>>
>> Rather than crashing, check the src ptr and set dst to empty string.
>>
>> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>
>
> Wouldn't it make more sense to check for the existence outside at the
> caller's side? That way it's much easier to see what really is happening.

It's much easier to allow NULL so that we can directly pass the return
result of getenv().

>
> Alex
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot


More information about the U-Boot mailing list