[U-Boot] [PATCH v2 3/3] efi_selftest: unit test for CalculateCrc32()

Heinrich Schuchardt xypron.glpk at gmx.de
Fri Jul 6 06:42:49 UTC 2018


On 07/06/2018 07:24 AM, Alexander Graf wrote:
> 
> 
> On 06.07.18 07:09, Heinrich Schuchardt wrote:
>> This unit test checks the CalculateCrc32 bootservice and checks the
>> headers of the system table, the boot services tablle, and the runtime
>> services table before and after ExitBootServices().
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> 
> This is a good step forward, thanks!
> 
> I still don't see any code that adapts the systab crc in
> efi_install_configuration_table(), so we're clearly missing a test case
> for this.

You are right. We are changing the field NumberOfTableEntries which is
part of the crc32. The field ConfigurationTable is currently not changed.

Best regards

Heinrich


More information about the U-Boot mailing list