[U-Boot] [PATCH v2 19/29] dtoc: Fix some minor errors

Simon Glass sjg at chromium.org
Fri Jul 6 16:27:32 UTC 2018


Fix some comments and a printf string which is incorrect.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v2: None

 tools/dtoc/dtb_platdata.py | 3 ++-
 tools/dtoc/dtoc.py         | 4 ++--
 tools/dtoc/fdt.py          | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py
index b1323aef19..6cb1259446 100644
--- a/tools/dtoc/dtb_platdata.py
+++ b/tools/dtoc/dtb_platdata.py
@@ -316,7 +316,8 @@ class DtbPlatdata(object):
             total = na + ns
 
             if reg.type != fdt.TYPE_INT:
-                raise ValueError("Node '%s' reg property is not an int")
+                raise ValueError("Node '%s' reg property is not an int" %
+                                 node.name)
             if len(reg.value) % total:
                 raise ValueError("Node '%s' reg property has %d cells "
                         'which is not a multiple of na + ns = %d + %d)' %
diff --git a/tools/dtoc/dtoc.py b/tools/dtoc/dtoc.py
index c891b06380..2e6a4db8bc 100755
--- a/tools/dtoc/dtoc.py
+++ b/tools/dtoc/dtoc.py
@@ -40,8 +40,8 @@ def run_tests(args):
     """Run all the test we have for dtoc
 
     Args:
-        args: List of positional args provided to binman. This can hold a test
-            name to execute (as in 'binman -t testSections', for example)
+        args: List of positional args provided to dtoc. This can hold a test
+            name to execute (as in 'dtoc -t test_empty_file', for example)
     """
     import test_dtoc
 
diff --git a/tools/dtoc/fdt.py b/tools/dtoc/fdt.py
index c1d04d48e8..e7703c1c75 100644
--- a/tools/dtoc/fdt.py
+++ b/tools/dtoc/fdt.py
@@ -428,7 +428,7 @@ class Fdt:
         return node
 
 def FdtScan(fname):
-    """Returns a new Fdt object from the implementation we are using"""
+    """Returns a new Fdt object"""
     dtb = Fdt(fname)
     dtb.Scan()
     return dtb
-- 
2.18.0.203.gfac676dfb9-goog



More information about the U-Boot mailing list