[U-Boot] [PATCH v2 3/6] efi_loader: remove unused efi_get_time_init()

Heinrich Schuchardt xypron.glpk at gmx.de
Sat Jul 7 21:39:13 UTC 2018


Remove unused function efi_get_time_init().

Initialization of the RTC has to be done in board bring up not in the EFI
subsystem.

There is no RTC device in the UEFI spec. The RTC is only accessed through
the runtime services.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
v2
	update commit message
---
 cmd/bootefi.c                | 3 ---
 include/efi_loader.h         | 1 -
 lib/efi_loader/efi_runtime.c | 5 -----
 3 files changed, 9 deletions(-)

diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index e57e70fc61..b60c151fb4 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -90,9 +90,6 @@ efi_status_t efi_init_obj_list(void)
 	ret = efi_reset_system_init();
 	if (ret != EFI_SUCCESS)
 		goto out;
-	ret = efi_get_time_init();
-	if (ret != EFI_SUCCESS)
-		goto out;
 
 out:
 	efi_obj_list_initialized = ret;
diff --git a/include/efi_loader.h b/include/efi_loader.h
index 8363a4c5f4..f162adfff7 100644
--- a/include/efi_loader.h
+++ b/include/efi_loader.h
@@ -437,7 +437,6 @@ efi_status_t efi_reset_system_init(void);
 efi_status_t __efi_runtime EFIAPI efi_get_time(
 			struct efi_time *time,
 			struct efi_time_cap *capabilities);
-efi_status_t efi_get_time_init(void);
 
 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
 /*
diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c
index 92175aebdb..f44e0555b7 100644
--- a/lib/efi_loader/efi_runtime.c
+++ b/lib/efi_loader/efi_runtime.c
@@ -186,11 +186,6 @@ efi_status_t __weak __efi_runtime EFIAPI efi_get_time(
 	return EFI_DEVICE_ERROR;
 }
 
-efi_status_t __weak efi_get_time_init(void)
-{
-	return EFI_SUCCESS;
-}
-
 struct efi_runtime_detach_list_struct {
 	void *ptr;
 	void *patchto;
-- 
2.18.0



More information about the U-Boot mailing list