[U-Boot] [PATCH 2/2] sandbox: Don't disable ctrlc() on sandbox if in raw mode

Simon Glass sjg at chromium.org
Mon Jul 9 02:39:34 UTC 2018


Hi Joe,

On 2 July 2018 at 18:06, Joe Hershberger <joe.hershberger at ni.com> wrote:
> In raw mode, handle ctrl-c as normal. This allows normal ctrl-c behavior
> such as aborting a command that is timing out without completely
> terminating the sandbox executable.
>
> In [1], Simon disabled this.  His reason for it was that it interferes
> with piping test scripts. Piping should be done in cooked mode, so this
> change should still not interfere.
>
> [1] commit 8969ea3e9f2db04a6b3675 ("sandbox: Disable Ctrl-C")
>
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>
> ---
>
>  common/console.c         | 2 --
>  drivers/serial/sandbox.c | 3 +++
>  2 files changed, 3 insertions(+), 2 deletions(-)

It is designed so that ctrl-C exits in raw mode. That is the normal
behaviour for an application and I don't think sandbox should be any
different.

How about using cooked mode instead?

Regards,
Simon


More information about the U-Boot mailing list