[U-Boot] [PATCH 1/1] efi_loader: rename utf16_strlen, utf16_strnlen

Alexander Graf agraf at suse.de
Mon Jul 9 04:15:29 UTC 2018



On 05.07.18 19:39, Heinrich Schuchardt wrote:
> The function names utf16_strlen() and utf16_strnlen() are misnomers.
> The functions do not count utf-16 characters but non-zero words.
> So let's rename them to u16_strlen and u16_strnlen().
> 
> In utf16_dup() avoid assignment in if clause.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

We had quite a long debate back when the patches got created whether we
should call these utf16 or ucs2. I don't remember if we ever got to a
full conclusion.

I think the u16 name is even more obvious though, so I'm in agreement
with this patch.

Rob, please ack if you also think it's good.


Alex


More information about the U-Boot mailing list