[U-Boot] [PATCH] cmd: ubi: change 'default y' for SUNXI to 'imply' in Kconfig

[Maxime Ripard]

On Mon, Jul 09, 2018 at 03:12:37PM +0900, Masahiro Yamada wrote:
> It is not preferred to put SUNXI-specific code in the common place.

I think Tom has been saying the exact opposite a number of times,
since there's some circular dependencies issues that arise when using
imply.

Maxime

> Change it to 'imply' property of ARCH_SUNXI.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
> 
>  arch/arm/Kconfig | 1 +
>  cmd/Kconfig      | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 7d394f2..a6ce155 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -796,6 +796,7 @@ config ARCH_SUNXI
>  	select USB_KEYBOARD if DISTRO_DEFAULTS
>  	select USE_TINY_PRINTF
>  	imply CMD_GPT
> +	imply CMD_UBI if NAND
>  	imply DISTRO_DEFAULTS
>  	imply FAT_WRITE
>  	imply OF_LIBFDT_OVERLAY
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index aec2090..159ebaa 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1792,7 +1792,6 @@ config CMD_UBI
>  	select CRC32
>  	select MTD_UBI
>  	select CMD_MTDPARTS
> -	default y if NAND_SUNXI
>  	help
>  	  UBI is a software layer above MTD layer which admits use of LVM-like
>  	  logical volumes on top of MTD devices, hides some complexities of
> -- 
> 2.7.4
> 

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180709/13796695/attachment.sig>