[U-Boot] [PATCH v3 3/7] misc: fsl_portals: setup QMAN_BAR{E} also on ARM platforms

[Bharat Bhushan]

> -----Original Message-----
> From: Laurentiu Tudor
> Sent: Monday, July 9, 2018 6:10 PM
> To: Bharat Bhushan <bharat.bhushan at nxp.com>; York Sun
> <york.sun at nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH v3 3/7] misc: fsl_portals: setup QMAN_BAR{E} also on
> ARM platforms
> 
> Hi Bharat,
> 
> On 09.07.2018 15:06, Bharat Bhushan wrote:
> >
> >
> >> -----Original Message-----
> >> From: Laurentiu Tudor [mailto:laurentiu.tudor at nxp.com]
> >> Sent: Wednesday, July 4, 2018 7:44 PM
> >> To: York Sun <york.sun at nxp.com>; Prabhakar Kushwaha
> >> <prabhakar.kushwaha at nxp.com>; u-boot at lists.denx.de
> >> Cc: Bharat Bhushan <bharat.bhushan at nxp.com>; Laurentiu Tudor
> >> <laurentiu.tudor at nxp.com>
> >> Subject: [PATCH v3 3/7] misc: fsl_portals: setup QMAN_BAR{E} also on
> >> ARM platforms
> >>
> >> QMAN_BAR{E} register setup was disabled on ARM platforms, however
> the
> >> register does need to be set. Enable the code also on ARMs and fix
> >> the CONFIG_SYS_QMAN_MEM_PHYS define to the correct value so that
> the
> >> newly enabled code works.
> >>
> >> Signed-off-by: Laurentiu Tudor <laurentiu.tudor at nxp.com>
> >> ---
> >>   arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h | 3 +--
> >>   drivers/misc/fsl_portals.c                             | 2 --
> >>   2 files changed, 1 insertion(+), 4 deletions(-)
> >>
> >> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> >> b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> >> index 644a16dd30..d22ec70aa5 100644
> >> --- a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> >> +++ b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> >> @@ -57,8 +57,7 @@
> >>   #define CONFIG_SYS_BMAN_SWP_ISDR_REG    0x3E80
> >>   #define CONFIG_SYS_QMAN_NUM_PORTALS	10
> >>   #define CONFIG_SYS_QMAN_MEM_BASE	0x500000000
> >> -#define CONFIG_SYS_QMAN_MEM_PHYS	(0xf00000000ull + \
> >> -
> >> 	CONFIG_SYS_QMAN_MEM_BASE)
> >> +#define CONFIG_SYS_QMAN_MEM_PHYS
> >> 	CONFIG_SYS_QMAN_MEM_BASE
> >
> > Are you sure that these changes works for PowerPC ?
> >
> 
> Can't imagine how it could happen. immap_lsch2.h is a ls104xa specific file.

Ahh yes, just missed 😊

Thanks
-Bharat


> 
> ---
> Thanks & Best Regards, Laurentiu