[U-Boot] [PATCH 1/3] net: phy: ti: Modify to support livetree

[Siva Durga Prasad Paladugu]

Hi,


> -----Original Message-----
> From: Siva Durga Prasad Paladugu
> Sent: Tuesday, July 10, 2018 9:32 AM
> To: Grygorii Strashko <grygorii.strashko at ti.com>; u-boot at lists.denx.de
> Cc: joe.hershberger at ni.com; Michal Simek <michals at xilinx.com>
> Subject: RE: [U-Boot] [PATCH 1/3] net: phy: ti: Modify to support livetree
> 
> Hi,
> 
> > -----Original Message-----
> > From: Grygorii Strashko [mailto:grygorii.strashko at ti.com]
> > Sent: Monday, July 09, 2018 10:51 PM
> > To: Siva Durga Prasad Paladugu <sivadur at xilinx.com>; u-
> > boot at lists.denx.de
> > Cc: joe.hershberger at ni.com; Michal Simek <michals at xilinx.com>
> > Subject: Re: [U-Boot] [PATCH 1/3] net: phy: ti: Modify to support
> > livetree
> >
> >
> >
> > On 07/06/2018 05:10 AM, Siva Durga Prasad Paladugu wrote:
> > > This patch adds support for livetree by using dev_.. calls instead
> > > of fdtdec_..
> > >
> > > Signed-off-by: Siva Durga Prasad Paladugu
> > > <siva.durga.paladugu at xilinx.com>
> > > ---
> > >   drivers/net/phy/ti.c | 16 +++++++---------
> > >   1 file changed, 7 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c index
> > > 8f3ed8a..945d9e9 100644
> > > --- a/drivers/net/phy/ti.c
> > > +++ b/drivers/net/phy/ti.c
> > > @@ -173,24 +173,22 @@ static int dp83867_of_init(struct phy_device
> > *phydev)
> > >   {
> > >   	struct dp83867_private *dp83867 = phydev->priv;
> > >   	struct udevice *dev = phydev->dev;
> > > -	int node = dev_of_offset(dev);
> > >   	const void *fdt = gd->fdt_blob;
> > >
> > > -	if (fdtdec_get_bool(fdt, node, "ti,max-output-impedance"))
> > > +	if (dev_read_bool(dev, "ti,max-output-impedance"))
> > >   		dp83867->io_impedance =
> > DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX;
> > > -	else if (fdtdec_get_bool(fdt, node, "ti,min-output-impedance"))
> > > +	else if (dev_read_bool(dev, "ti,min-output-impedance"))
> > >   		dp83867->io_impedance =
> > DP83867_IO_MUX_CFG_IO_IMPEDANCE_MIN;
> > >   	else
> > >   		dp83867->io_impedance = -EINVAL;
> > >
> > > -	dp83867->rx_id_delay = fdtdec_get_uint(gd->fdt_blob,
> > dev_of_offset(dev),
> > > -				 "ti,rx-internal-delay", -1);
> > > +	dp83867->rx_id_delay = dev_read_u32_default(dev, "ti,rx-internal-
> > delay",
> > > +						    -1);
> > >
> > > -	dp83867->tx_id_delay = fdtdec_get_uint(gd->fdt_blob,
> > dev_of_offset(dev),
> > > -				 "ti,tx-internal-delay", -1);
> > > +	dp83867->tx_id_delay = dev_read_u32_default(dev, "ti,tx-internal-
> > delay",
> > > +						    -1);
> > >
> > > -	dp83867->fifo_depth = fdtdec_get_uint(gd->fdt_blob,
> > dev_of_offset(dev),
> > > -				 "ti,fifo-depth", -1);
> > > +	dp83867->fifo_depth = dev_read_u32_default(dev, "ti,fifo-depth",
> > > +-1);
> > >
> > >   	return 0;
> > >   }
> > >
> >
> > NACK. Pls, check
> > https://patchwork.ozlabs.org/cover/936370/
> > and
> > https://patchwork.ozlabs.org/cover/936380/
> >
> > any comments, tested-by are very welcome.
> 
> Do you mean to say that this patch has to be rebased and tested on the top
> of your patch.

Oops, I missed your second thread(936380) and replied. 
Please ignore my last mail. 
I will review, test with your series and let you know if any.

Thanks,
Siva

> 
> Thanks,
> Siva
> 
> >
> > --
> > regards,
> > -grygorii