[U-Boot] [PATCH 1/1] Fix README for Khadas VIM board

[Loic Devulder]

Hi Neil,

On 07/10/2018 03:43 PM, Neil Armstrong wrote:
> Hi Loic,
> 
> On 10/07/2018 15:15, Loic Devulder wrote:
>> Fix documentation to be able to cross-compile U-Boot on Khadas VIM board.
>>
>> Signed-off-by: Loic Devulder <ldevulder at suse.de>
>> ---
>>  board/amlogic/khadas-vim/README | 32 +++++++++++++++++++++++++-------
>>  1 file changed, 25 insertions(+), 7 deletions(-)
>>
>> diff --git a/board/amlogic/khadas-vim/README b/board/amlogic/khadas-vim/README
>> index 7eaca724f8..0f912e9fcd 100644
>> --- a/board/amlogic/khadas-vim/README
>> +++ b/board/amlogic/khadas-vim/README
>> @@ -20,12 +20,19 @@ Currently the u-boot port supports the following devices:
>>   - serial
>>   - eMMC, microSD
>>   - Ethernet
>> + - USB
> 
> This will collide with my previous patch "boards: amlogic: Fix boards README"

I was not aware of it sorry, so yes this can be removed.

> 
>>  
>>  U-Boot compilation
>>  ==================
>>  
>> + > mkdir ~/cross-compile
>> + > cd ~/cross-compile
>> + > wget -c https://releases.linaro.org/components/toolchain/binaries/latest/aarch64-elf/gcc-linaro-7.2.1-2017.11-x86_64_aarch64-elf.tar.xz
>> + > tar xvfJ gcc-linaro-7.2.1-2017.11-x86_64_aarch64-elf.tar.xz
>> + > export PATH=$PWD/gcc-linaro-7.2.1-2017.11-x86_64_aarch64-elf:$PATH
>> + > cd <u-boot_src_directory>
>>   > export ARCH=arm
>> - > export CROSS_COMPILE=aarch64-none-elf-
>> + > export CROSS_COMPILE=aarch64-elf-
>>   > make khadas-vim_defconfig
>>   > make
>>  
>> @@ -36,20 +43,31 @@ Amlogic doesn't provide sources for the firmware and for tools needed
>>  to create the bootloader image, so it is necessary to obtain them from
>>  the git tree published by the board vendor:
>>  
>> - > wget https://releases.linaro.org/archive/13.11/components/toolchain/binaries/gcc-linaro-aarch64-none-elf-4.8-2013.11_linux.tar.xz
>> - > wget https://releases.linaro.org/archive/13.11/components/toolchain/binaries/gcc-linaro-arm-none-eabi-4.8-2013.11_linux.tar.xz
>> +To be able to compile the *old* U-Boot (if needed):
>> + > Remove the *new* gcc-7.2 from the PATH
>> + > cd ~/cross-compile
>> + > wget -c https://releases.linaro.org/components/toolchain/binaries/4.9-2017.01/aarch64-elf/gcc-linaro-4.9.4-2017.01-x86_64_aarch64-elf.tar.xz
>>   > tar xvfJ gcc-linaro-aarch64-none-elf-4.8-2013.11_linux.tar.xz
>> + > export PATH=$PWD/gcc-linaro-4.9.4-2017.01-x86_64_aarch64-elf/bin:$PATH
>> +
>> +To compile the ATF firmware:
>> + > cd ~/cross-compile
>> + > wget -c https://releases.linaro.org/archive/13.11/components/toolchain/binaries/gcc-linaro-arm-none-eabi-4.8-2013.11_linux.tar.xz
>>   > tar xvfJ gcc-linaro-arm-none-eabi-4.8-2013.11_linux.tar.xz
>> - > export PATH=$PWD/gcc-linaro-aarch64-none-elf-4.8-2013.11_linux/bin:$PWD/gcc-linaro-arm-none-eabi-4.8-2013.11_linux/bin:$PATH
>> + > export PATH=$PWD/gcc-linaro-arm-none-eabi-4.8-2013.11_linux/bin:$PATH
>> +
>> + > cd <where_you_want_to_put_vim-u-boot>
>>   > git clone https://github.com/khadas/u-boot -b Vim vim-u-boot
>>   > cd vim-u-boot
>> + > export ARCH=arm
>> + > export CROSS_COMPILE=aarch64-elf-
>>   > make kvim_defconfig
>>   > make
>> - > export FIPDIR=$PWD/fip
>>  
>>  Go back to mainline U-Boot source tree then :
>> + > export FIPDIR=$PWD/fip
>> + > cd <u-boot_src_directory>
>>   > mkdir fip
>> -
>>   > cp $FIPDIR/gxl/bl2.bin fip/
>>   > cp $FIPDIR/gxl/acs.bin fip/
>>   > cp $FIPDIR/gxl/bl21.bin fip/
>> @@ -67,7 +85,7 @@ Go back to mainline U-Boot source tree then :
>>  	fip/bl30_new.bin \
>>  	bl30
>>  
>> - > $FIPDIR/acs_tool.pyc fip/bl2.bin fip/bl2_acs.bin fip/acs.bin 0
>> + > python $FIPDIR/acs_tool.pyc fip/bl2.bin fip/bl2_acs.bin fip/acs.bin 0
> 
> Apart this line, I don't see the point of all the other changes ? Can you elaborate ?
> 
> These instructions are already made to cross-compile U-boot, is there an issue with the instructions ?

I had some issues with the cross compiler, mainly since U-Boot needs or
more recent gcc, that's why I added a section/example with gcc v7.

It took me some times to find the correct configuration, that's why I do
this changes, for people like me :)

But yes the 'python' part is the most important I think, to avoid
failing compilation on some Linux OSes. As for the other changes, if you
think that they are not needed no problem, I can remove them.

> 
>>  
>>   > $FIPDIR/blx_fix.sh \
>>  	fip/bl2_acs.bin \
>>
> 
> 
> Neil
> 

-- 
Loic Devulder - Senior QA Engineer
Container & Storage Solutions Quality Assurance team (qa-css)
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB,
21284 (AG Nuernberg)