[U-Boot] [PATCH v3 7/7] armv8: ls1046a: setup fman ports ICIDs and device tree

[York Sun]

On 07/09/2018 05:26 AM, Bharat Bhushan wrote:

<snip>

>> @@ -74,7 +79,12 @@ void fdt_fixup_icid(void *blob);
>>  		CONFIG_SYS_FSL_BMAN_ADDR, \
>>  		CONFIG_SYS_FSL_BMAN_ADDR)
>>
>> +#define SET_FMAN_ICID_ENTRY(_port_id, _icid) \
>> +	{ .port_id = (_port_id), .icid = (_icid) }
> 
> Same comment as in 6/7 patch applies here also, use "streamed" or "icid" consistent with h/w or devicetree.
> 

Guys,

The discussion is healthy. Please trim the quoted messages to keep only
relevant context to make the comments easy to read. Thanks.

York