[U-Boot] [PATCH v3 4/4] rk3288: Convert register defines to const uintptr_t

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Fri Jul 13 10:26:30 UTC 2018


> On 9 Jul 2018, at 05:05, Simon Glass <sjg at chromium.org> wrote:
> 
> On 11 June 2018 at 13:00, Carlo Caione <carlo at caione.org> wrote:
>> From: Carlo Caione <carlo at endlessm.com>
>> 
>> No functional change but at least we can now guarantee type safety.
>> 
>> Signed-off-by: Carlo Caione <carlo at endlessm.com>
>> ---
>> arch/arm/mach-rockchip/rk3288-board.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I'm not sure this affects type safety. The value in the #define has
> the same value (and type) as your variables.

I prefer this as locally defined const variables, so I’ve squashed this onto 2/4.

Philipp.


More information about the U-Boot mailing list