[U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Fri Jul 13 10:42:34 UTC 2018


Joe,

> On 14 Jun 2018, at 20:26, Joe Hershberger <joe.hershberger at ni.com> wrote:
> 
> On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich
> <philipp.tomsich at theobroma-systems.com> wrote:
>> 
>>> On 14 Jun 2018, at 19:39, Joe Hershberger <joe.hershberger at ni.com> wrote:
>>> 
>>> On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann <j.hagemann at phytec.de> wrote:
>>>> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of
>>>> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii()
>>>> to enable the RX delay.
>>>> The MASK was used in a wrong way.
>>>> 
>>>> Signed-off-by: Janine Hagemann <j.hagemann at phytec.de>
>>> 
>>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>> 
>> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> 
> I assume I should take this series? Or would you prefer to?


I’ll take these as part of the larger series.

Thanks,
Philipp.


More information about the U-Boot mailing list