[U-Boot] [PATCH] sysreset: Add support for gpio-restart

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Fri Jul 13 12:58:22 UTC 2018


> On 13 Jul 2018, at 11:15, Michal Simek <michal.simek at xilinx.com> wrote:
> 
> The Linux kernel has binding for gpio-restart node.
> This patch is adding basic support without supporting any optional
> properties.

Nice. This may also give us an opportunity to streamline some of the reset
logic (and the FDT-interface to the ATF) on our RK3399-Q7 board.

> This driver was tested on Microblaze system where gpio is connected to
> SoC reset logic.
> Output value is handled via gpios cells values.
> 
> In gpio_reboot_request() set_value is writing 1 because
> dm_gpio_set_value() is capable to changing it when it is ACTIVE_LOW.
> ...
> 	if (desc->flags & GPIOD_ACTIVE_LOW)
> 		value = !value;
> ...
> 
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>

Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>



More information about the U-Boot mailing list